Improve error catching #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
requested review from
BearHanded,
braxex and
jessabean
as code owners
gmrabian
requested review from
ntsummers1,
britt-mo,
karla-vm,
benmartin-coforma and
bangbay-bluetiger
karla-vm
previously approved these changes
Sep 20, 2024
gmrabian
dismissed stale reviews from benmartin-coforma and karla-vm
via
1fb1482
|
Code Climate has analyzed commit bd2f853 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.9% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.1% (0.0% change). View more on Code Climate. |
karla-vm
approved these changes
Sep 23, 2024
benmartin-coforma
approved these changes
Sep 23, 2024
jessabean
approved these changes
Sep 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had certain return blocks based on variables being undefined where they could not be undefined as a result of their flow. This fixes that logic with try/catches and builds on our new response pattern
Related ticket(s)
CMDCT-3988
How to test
All tests pass
Everything works as normal
If you resend a request locally with invalid fieldData or metadata if throws a 400 with the proper error message
Notes
Pre-review checklist